refactor: Sink DSL and callback for Iceberg#27258
Open
nameexhaustion wants to merge 2 commits intomainfrom
Open
refactor: Sink DSL and callback for Iceberg#27258nameexhaustion wants to merge 2 commits intomainfrom
nameexhaustion wants to merge 2 commits intomainfrom
Conversation
Contributor
|
The uncompressed lib size after this PR is 58.9041 MB. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #27258 +/- ##
==========================================
- Coverage 81.80% 81.19% -0.61%
==========================================
Files 1816 1821 +5
Lines 250592 251105 +513
Branches 3144 3144
==========================================
- Hits 204985 203882 -1103
- Misses 44803 46423 +1620
+ Partials 804 800 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SinkType::Icebergto the DSL, replacing the existing usage of::PipeWithSchemaSinkedPathsCallback::IcebergCommitvariant, and refactors Iceberg commit to use this callback instead of a separate file-listing