perf: Avoid unnecessary rechunk when sorting already sorted DataFrame#27264
Open
gab23r wants to merge 2 commits intopola-rs:mainfrom
Open
perf: Avoid unnecessary rechunk when sorting already sorted DataFrame#27264gab23r wants to merge 2 commits intopola-rs:mainfrom
gab23r wants to merge 2 commits intopola-rs:mainfrom
Conversation
8e37f7e to
28f38b5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27264 +/- ##
=======================================
Coverage 81.56% 81.57%
=======================================
Files 1820 1820
Lines 251061 251060 -1
Branches 3149 3149
=======================================
+ Hits 204788 204796 +8
+ Misses 45465 45456 -9
Partials 808 808 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25733
Removed unconditional
rechunk_mut_par()call from the sort executor.sort_implalready handles rechunking after checking if a fast path (already sorted) can be taken, so the executor's rechunk was redundant