Implement input method support to COSMIC-edit specific text widgets (for iced-rebase branch)#539
Draft
kenz-gelsoft wants to merge 3 commits intopop-os:masterfrom
Draft
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input method support in iced 14.0 requires text widgets to implement some logic to support input method input. This PR includes this for the
cosmic-editspecific text widgets.This PR depends on my pop-os/libcosmic fork. Please see PR I opened:
(I will force-push this branch to update my fork to rebase to newer upstream rev)