Fix handling of scroll events, fix auto-hide on compositors where intellihide isn't supported, refactor #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now these don't all need to be passed to `PanelSpace::new()` as seperate arguments.
The body is just a call to `Option::map`; so if it's supposed to be doing anything, it appears not to.
Makes the panel usable on compositors without the `cosmic-overlap-notify-unstable-v1` protocol. The dock now hides as it should on Sway.
* Absolute events should not be multiplied by 120 * Handle `value120` scroll events
jacobgkau
approved these changes
Oct 13, 2025
mmstick
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't multiply absolute scroll events by 120, and handle
value120scroll events.Without this, pop-os/cosmic-applets#1102 doesn't work properly. The existing version of that applet still seems to work fine with this change as well.
Also includes an earlier change I hadn't PR'ed to fix auto-hide behavior on compositors other than cosmic-comp, and some refactoring. Those shouldn't have any impact on behavior on cosmic-comp.