This repository was archived by the owner on Oct 8, 2025. It is now read-only.
settings_daemon: Update brightness on name-owner change #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send events is settings daemon is started after the start of this subscription, or if it is restarted. To get updates when the daemon wasn't running at the start of the stream, z-galaxy/zbus#1389 is also needed. Loss of the name owner should probably also disable any brightness controls, but if that's done by a change of the brightness values and not by a seperate property, we probably can't rely on the ordering of events from different streams...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send events is settings daemon is started after the start of this subscription, or if it is restarted.
To get updates when the daemon wasn't running at the start of the stream, z-galaxy/zbus#1389 is also needed.
Loss of the name owner should probably also disable any brightness controls, but if that's done by a change of the brightness values and not by a seperate property, we probably can't rely on the ordering of events from different streams...
The status area applet should probably also check for name owner loss. Well-ordered handling of name owner changes is also a concern for pop-os/cosmic-comp#1412.