Adjust speed of pointer scrolling #220
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ids1024
force-pushed
the
scroll-speed
branch
3 times, most recently
from
1c93643 to
6721e03
Compare
Matches the behavior of scrolling over the applet. Seems reasonable.
Combined with pop-os/iced#244, discrete value120 scrolling works better.
This is an expected case, not an error.
|
pop-os/libcosmic#1020 moves the scroll handling code to libcosmic so it can be shared with cosmic-applet-workspaces, or anywhere else we need discrete scrolling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#134.
Scrolling between workspaces in 16 px intervals instead of 4 px seems better on a touchpad.
This doesn't seem ideal with a mouse with a scroll wheel. That should be producing
ScrollDelta::Linesrather thanScrollDelta::Pixelsevents, I think? I guess we're not handlingaxis_v120events from the compositor...We should make the scroll handing in cosmic-applet-workspaces match as well.