Don't error when default config for toolkit settings is not present #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like pop-os/cosmic-settings-daemon#100. We don't appear to install default configs for these settings anywhere? And we may not want libcosmic to inherently depend on globally installed config files. So just avoid printing errors in that case. We may want to consider what errors `ConfigGet` returns (#948) but this should do for now. This should help with a big part of the log spam libcosmic is currently producing.
mmstick
approved these changes
Aug 22, 2025
ids1024
added a commit
that referenced
this pull request
Aug 22, 2025
* Use `tracing::error!` in places where `eprintln!` was used * Loop over errors and print seperately * Print errors with `Display` rather than `Debug` * Don't print errors that should be ignored - Matches #949, for same reasons. With this, and the previous change, cosmic-panel no longer spams a bunch of config errors from different applets on start.
mmstick
pushed a commit
that referenced
this pull request
Aug 22, 2025
* Use `tracing::error!` in places where `eprintln!` was used * Loop over errors and print seperately * Print errors with `Display` rather than `Debug` * Don't print errors that should be ignored - Matches #949, for same reasons. With this, and the previous change, cosmic-panel no longer spams a bunch of config errors from different applets on start.
ids1024
added a commit
to pop-os/cosmic-applets
that referenced
this pull request
Aug 25, 2025
With pop-os/libcosmic#949 and pop-os/libcosmic#950, `journalctl /usr/bin/cosmic-panel --follow` no longer shows a bunch of config error message span when the panel is started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like pop-os/cosmic-settings-daemon#100. We don't appear to install default configs for these settings anywhere? And we may not want libcosmic to inherently depend on globally installed config files.
So just avoid printing errors in that case.
We may want to consider what errors
ConfigGetreturns (#948) but this should do for now.This should help with a big part of the log spam libcosmic is currently producing.