Added success_conclusions and timeout_behavior inputs#753
Open
ignacio-circle2 wants to merge 2 commits intoposeidon:mainfrom
Open
Added success_conclusions and timeout_behavior inputs#753ignacio-circle2 wants to merge 2 commits intoposeidon:mainfrom
success_conclusions and timeout_behavior inputs#753ignacio-circle2 wants to merge 2 commits intoposeidon:mainfrom
Conversation
|
Please take this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Added Configurable Success Criteria and Timeout Behavior
This PR adds two new optional inputs to make the action more flexible while maintaining complete backward compatibility.
✨ New Features
1. Configurable Success Conclusions (
success_conclusions)'success,skipped'(maintains current behavior)2. Configurable Timeout Behavior (
timeout_behavior)'fail'(maintains current behavior)'fail'|'success'🎯 Use Cases
Flexible Success Criteria:
'neutral'conclusions as successful for some workflows'success'(exclude'skipped') for strict validationTimeout Flexibility:
'fail'(default): Strict enforcement - all checks must complete within timeout'success': Non-blocking CI - trust that slow checks will eventually pass🔒 Validation & Safety
📝 Examples
Current behavior (unchanged):
Strict validation:
Flexible/optimistic:
🔧 Implementation Details
isFailure()function: Now accepts configurable success conclusions arrayThis maintains the action's reliability while providing the flexibility requested by users who need different success criteria or timeout handling for their specific CI/CD workflows.