Skip to content

Make DAP an unmanaged comm #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 20, 2025
Merged

Make DAP an unmanaged comm #901

merged 5 commits into from
Sep 20, 2025
+287 −90

Conversation

lionel-
Copy link
Contributor

@lionel- lionel- commented Aug 20, 2025

@lionel- lionel- force-pushed the task/dap-comm branch 3 times, most recently from f6a4221 to 914bce6 Compare August 28, 2025 10:35
@lionel- lionel- requested a review from jmcphers August 28, 2025 10:42
jmcphers
jmcphers approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@jmcphers jmcphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well w/ Positron side of the change

@lionel- lionel- merged commit 8e9f4b9 into main Sep 20, 2025
6 checks passed
@lionel- lionel- deleted the task/dap-comm branch September 20, 2025 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmcphers jmcphers jmcphers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionel- @jmcphers