Skip to content

avoid unwrap in interruptible invocations #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

avoid unwrap in interruptible invocations #922

wants to merge 1 commit into from

Conversation

kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Sep 18, 2025 •
edited
Loading

Closes posit-dev/positron#9467.

I'm not sure how pervasive this sort of issue might be, though. Could any usage of harp APIs theoretically be interrupted by the user? Or does harp need to suspend interrupts in more contexts?

lionel-
lionel- reviewed Sep 19, 2025
View reviewed changes
Copy link
Contributor

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I think I'd prefer to suspend interrupts in write_console() here. Trying to recover from failing R calls in these handlers seems a bit hard to reason about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionel- lionel- lionel- left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when interrupting after immediately submitting command
2 participants
@kevinushey @lionel-