Skip to content

Stub in an idea that gets R dev help to refresh #8087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Draft

Stub in an idea that gets R dev help to refresh #8087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/vs/workbench/contrib/positronHelp/browser/positronHelpService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,10 +433,13 @@ class PositronHelpService extends Disposable implements IPositronHelpService {
* @param helpEntry The help entry to add.
*/
private addHelpEntry(helpEntry: HelpEntry) {
// If the help entry being added matches the current help entry, don't open it again.
if (this._helpEntries[this._helpEntryIndex]?.sourceUrl === helpEntry.sourceUrl) {
return;
}
// Note: The frontend can't know whether the content underlying the url is fully static or not,
// so the frontend should not be in charge of whether or not we re-request the url content.
//
// // If the help entry being added matches the current help entry, don't open it again.
// if (this._helpEntries[this._helpEntryIndex]?.sourceUrl === helpEntry.sourceUrl) {
// return;
// }

// Splice the help entry into the help entries at the current help entry index and trim the
// remaining help entries to 10.
Expand Down