Address ResizeObserver not working in secondary windows by polling for size changes in the DataGridWaffle #9000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r size changes in the DataGridWaffle
|
E2E Tests 🚀 |
dhruvisompura
previously approved these changes
Aug 12, 2025
Comment on lines
95
to
100
| // ResizeObserver does not work well on elements inside secondary Electron windows. This causes issues | ||
| // with the data grid's automatic layout feature, which relies on knowing when the size of the data grid | ||
| // waffle changes. See https://github.com/posit-dev/positron/issues/8695. This workaround ensures that the | ||
| // initial data grid waffle's size is updated when the component is mounted. | ||
| DOM.getWindow(dataGridWaffleRef.current).requestAnimationFrame(async () => | ||
| await setSize(dataGridWaffleRef.current.offsetWidth, dataGridWaffleRef.current.offsetHeight) |
There was a problem hiding this comment.
Suggestion to change the comment to be a bit more explicit about why we are using requestAnimationFrame. This change is more for me if I ever have to look at this again 😂
Suggested change
| // ResizeObserver does not work well on elements inside secondary Electron windows. This causes issues | |
| // with the data grid's automatic layout feature, which relies on knowing when the size of the data grid | |
| // waffle changes. See https://github.com/posit-dev/positron/issues/8695. This workaround ensures that the | |
| // initial data grid waffle's size is updated when the component is mounted. | |
| DOM.getWindow(dataGridWaffleRef.current).requestAnimationFrame(async () => | |
| await setSize(dataGridWaffleRef.current.offsetWidth, dataGridWaffleRef.current.offsetHeight) | |
| // ResizeObserver does not work well on elements inside secondary Electron windows. This causes issues | |
| // with the data grid's automatic layout feature, which relies on knowing when the size of the data grid | |
| // waffle changes. See https://github.com/posit-dev/positron/issues/8695. Using `requestAnimationFrame` | |
| // ensures that the initial size of the data grid waffle is set when the component is mounted. | |
| DOM.getWindow(dataGridWaffleRef.current).requestAnimationFrame(async () => | |
| await setSize(dataGridWaffleRef.current.offsetWidth, dataGridWaffleRef.current.offsetHeight) |
softwarenerd
deleted the
fix/data-explorer-automatic-layout-fails-after-move-into-new-window
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #8695. The root cause of this issue is that ResizeObserver does not work well on elements inside secondary Electron windows. This causes issues with the Data Grid's automatic layout feature, which relies on knowing when the size of the Data Grid waffle changes. In a secondary Electron window, the workaround is to poll for changes in the Data Grid waffle’s size.
Release Notes
New Features
Bug Fixes
QA Notes