Assistant: enable positron assistant git integration by default #9073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
georgestagg
added a commit
that referenced
this pull request
Aug 19, 2025
* Completes the second half of the work requested by @jennybc in #8207, so that specific commit IDs can be added as context. * This should probably be merged and tested before enabling git integration by default, in #9073. ### QA Notes To test this integration: 0) Enable git integrations in user settings: `"positron.assistant.gitIntegration.enable": true`. 1) Load a project with an existing git repo and history into Positron. 2) Open a fresh chat window. Click "Add Context", "Source Control" and then select a specific commit from the quick pick menu. 3) Ensure the commit has been added as context: <img width="404" height="142" alt="Screenshot 2025-08-18 at 11 01 36" src="https://github.com/user-attachments/assets/38de2de3-877e-4950-8406-8e2f5d4cb75a" /> 4) Ask assistant about the commit. Confirm assistant can see the changes. <img width="656" height="572" alt="Screenshot 2025-08-18 at 11 02 56" src="https://github.com/user-attachments/assets/30a237f3-a890-4f3d-8f32-389cd124d95a" />
georgestagg
previously approved these changes
Aug 19, 2025
There was a problem hiding this comment.
#9075 has been merged, fixing a bug with git integration.
With that done, this LGTM!
nstrayer
pushed a commit
that referenced
this pull request
Aug 20, 2025
* Completes the second half of the work requested by @jennybc in #8207, so that specific commit IDs can be added as context. * This should probably be merged and tested before enabling git integration by default, in #9073. ### QA Notes To test this integration: 0) Enable git integrations in user settings: `"positron.assistant.gitIntegration.enable": true`. 1) Load a project with an existing git repo and history into Positron. 2) Open a fresh chat window. Click "Add Context", "Source Control" and then select a specific commit from the quick pick menu. 3) Ensure the commit has been added as context: <img width="404" height="142" alt="Screenshot 2025-08-18 at 11 01 36" src="https://github.com/user-attachments/assets/38de2de3-877e-4950-8406-8e2f5d4cb75a" /> 4) Ask assistant about the commit. Confirm assistant can see the changes. <img width="656" height="572" alt="Screenshot 2025-08-18 at 11 02 56" src="https://github.com/user-attachments/assets/30a237f3-a890-4f3d-8f32-389cd124d95a" />
|
Might want to wait for a decision about #9125 before merging this. |
sharon-wang
force-pushed
the
assistant/enable-git-integration-by-default
branch
from
80f4a1f to
db16fff
Compare
|
An update!
|
this will be helpful for enabling the source control context to debug the error in a web build, but still disables it by default for web and enables it by default for desktop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
positron.assistant.gitIntegration.enableto true and removes the experimental tag, but keeps the flag for nowSource Control...context item on Web due to Assistant: cannot get commit information when running in Workbench #9181Release Notes
New Features
QA Notes
See this PR for usage: #8257
Git features enabled by default!
positron.assistant.gitIntegration.enablesetting still available in the settings UI but is now enabled by defaultSource Control...context option disabled by default for Web/WorkbenchOn Web / Workbench, the
Source Control...context option should be missing:On Desktop, it should be available (some extra options because of my clipboard and editor state):
positron.assistant.gitIntegration.enablesetting can be used to makeSource Control...context option available on Web/Workbench"positron.assistant.sourceControlHistoryContext.enable": trueto the settings JSON in a web build to enable theSource Control...context option (helpful for debugging)