Positron Notebooks: Inline Chat #9147
Conversation
|
E2E Tests 🚀 |
| // --- Start Positron --- | ||
| // Find the Positron notebook instance for the given URI and containing the given editor. | ||
| for (const notebookInstance of positronNotebookService.getInstances()) { | ||
| if (isEqual(notebookInstance.uri, data.notebook)) { | ||
| const candidate = `<positron-notebook>${notebookInstance.id}#${uri}`; | ||
| if (!fallback) { | ||
| fallback = candidate; | ||
| } | ||
| if (notebookInstance.cells.get().some(cell => cell.editor === editor)) { | ||
| return candidate; | ||
| } | ||
| } | ||
| } | ||
| // --- End Positron --- |
There was a problem hiding this comment.
I wonder if we could put this type of thing into the instance itself. The logic would probably be the same just a different location.
There was a problem hiding this comment.
I've moved a bunch of it to the service and instance
| * TODO: Some notebook functionality (possibly debugging and outlines) require that the editor control | ||
| * also have a `notebookEditor: INotebookEditor` property. We'll need to investigate what that unlocks, | ||
| * whether to implement INotebookEditor, or find a different solution. | ||
| */ |
There was a problem hiding this comment.
Yeah this is something i've been mildly dreading implementing, glad we have a scaffold now!
There was a problem hiding this comment.
I spent a bunch of time looking into INotebookEditor, and I'm not totally convinced we should implement it. Worth a discussion though
| notebookInstance.selectionStateMachine.onNewState((state) => { | ||
| if (state.type === SelectionState.EditingSelection) { | ||
| this._activeCodeEditor = state.selectedCell.editor; | ||
| } else if (state.type === SelectionState.NoSelection) { | ||
| this._activeCodeEditor = undefined; | ||
| } else { | ||
| this._activeCodeEditor = state.selected[0]?.editor; | ||
| } | ||
| }) | ||
| ); |
There was a problem hiding this comment.
I'm curious how you find the selection state machine. You're the first person outside of me to touch it and it is a bit... different than what vscode does.
There was a problem hiding this comment.
The selection state machine is :chef-kissed-fingers:
| @@ -5,8 +5,9 @@ | |||
|
|
|||
| import { VSBuffer } from '../../../../base/common/buffer.js'; | |||
| import { Disposable } from '../../../../base/common/lifecycle.js'; | |||
| import { ISettableObservable } from '../../../../base/common/observableInternal/base.js'; | |||
There was a problem hiding this comment.
Did this path change recently? I keep needing to make this change everywhere.
seeM
force-pushed
the
feature/positron-notebooks-inline-chat
branch
from
a3b992e to
b978511
Compare
seeM
force-pushed
the
feature/positron-notebooks-inline-chat
branch
from
ad1d8bb to
d70dd4c
Compare
Addresses #8733.
Release Notes
New Features
Bug Fixes
QA Notes
@:notebooks @:assistant