Skip to content

Data Explorer: Add option to VerticalSplitter to always show the collapse button in the data explorer #9148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
Merged

Data Explorer: Add option to VerticalSplitter to always show the collapse button in the data explorer #9148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/vs/base/browser/ui/positronComponents/splitters/verticalSplitter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,12 @@ type VerticalSplitterCollapseProps = | {
readonly collapsible?: false;
readonly isCollapsed?: never;
readonly onCollapsedChanged?: never;
readonly alwaysShowExpandCollapseButton?: never;
} | {
readonly collapsible: true;
readonly isCollapsed: boolean;
readonly onCollapsedChanged: (collapsed: boolean) => void;
readonly alwaysShowExpandCollapseButton?: boolean;
};

/**
Expand Down Expand Up @@ -80,6 +82,7 @@ const getSashSize = (configurationService: IConfigurationService) =>
const getHoverDelay = (configurationService: IConfigurationService) =>
configurationService.getValue<number>('workbench.sash.hoverDelay');


/**
* Determines whether a point is inside an element.
* @param x The X coordinate.
Expand Down Expand Up @@ -136,6 +139,7 @@ export const VerticalSplitter = ({
showSash,
collapsible,
isCollapsed,
alwaysShowExpandCollapseButton,
onCollapsedChanged,
onBeginResize,
onResize,
Expand Down Expand Up @@ -412,7 +416,7 @@ export const VerticalSplitter = ({
/>
}
</div>
{collapsible && (hovering || resizing || collapsed) &&
{collapsible && (alwaysShowExpandCollapseButton || hovering || resizing || collapsed) &&
<Button
ref={expandCollapseButtonRef}
className='expand-collapse-button'
Expand Down
1 change: 1 addition & 0 deletions ...nch/browser/positronDataExplorer/components/dataExplorerPanel/components/dataExplorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,7 @@ export const DataExplorer = () => {
}
<div ref={splitterRef} className='splitter'>
<VerticalSplitter
alwaysShowExpandCollapseButton={true}
collapsible={true}
invert={layout === PositronDataExplorerLayout.SummaryOnRight}
isCollapsed={columnsCollapsed}
Expand Down