PositroNB extension API integration #9843
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ShowNotebookDocument
seeM
force-pushed
the
feature/positron-nb-extension-api
branch
from
a115b59 to
9fa2fec
Compare
|
E2E Tests 🚀 |
nstrayer
approved these changes
Oct 9, 2025
| // Get all Positron notebook instances | ||
| const instances = new Map<string, IPositronNotebookInstance>(); | ||
| for (const instance of this._positronNotebookService.listInstances()) { | ||
| if (instance.textModel) { |
There was a problem hiding this comment.
Wont this always be true because textModel is an observable? Should it be instance.textModel.get()?
| super.dispose(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| /** | |
| * Extracts the Positron notebook instance from a generic editor pane, if it contains one. | |
| * | |
| * The workbench editor service deals with generic `IEditorPane` objects that could | |
| * represent any type of editor (text, notebook, diff, etc.). When integrating Positron notebooks | |
| * with the extension API, we need to identify which editor panes contain Positron notebooks. | |
| * | |
| * @returns The notebook instance if the pane is a Positron notebook editor, undefined otherwise | |
| */ |
I found myself needing to look at this to get context so a docstring may help.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates Positron notebook editors with the extension API, addresses #9440. This is a more focused alternative to #9709.
Release Notes
New Features
Bug Fixes
QA Notes
Nothing should break. I'll follow up with another PR that adds cell debugging to Positron notebooks which will make it possible to QA this functionality.
@:notebooks