feat(toast): toast service implementation (#UIM-829)#731
Open
vladimirverbitski wants to merge 102 commits into
Open
feat(toast): toast service implementation (#UIM-829)#731vladimirverbitski wants to merge 102 commits into
vladimirverbitski wants to merge 102 commits into
Conversation
vladimirverbitski
requested review from
lskramarov and
pimenovoleg
as code owners
lskramarov
reviewed
Dec 3, 2021
| } | ||
|
|
||
| ngOnInit(): void { | ||
| this.intervalId = setTimeout(() => this.animationState = 'closing', this.toast.duration); |
Contributor
There was a problem hiding this comment.
по возможности нужно избегать setTimout... в других компонентах есть примеры с запуском анимации, посмотри, возможно получиться улучшить.
new colors for links
lskramarov
changed the title
lskramarov
force-pushed
the
feature/UID-1108
branch
from
8e3cee4 to
53b5329
Compare
…ID-1108 # Conflicts: # packages/docs/src/styles/default-theme/_variables.scss # packages/docs/src/styles/default-theme/css-tokens.css # packages/docs/src/styles/default-theme/tokens.ts # packages/docs/src/styles/green-theme/_variables.scss # packages/docs/src/styles/green-theme/css-tokens.css # packages/docs/src/styles/green-theme/tokens.ts # packages/docs/src/styles/red-theme/_variables.scss # packages/docs/src/styles/red-theme/css-tokens.css # packages/docs/src/styles/red-theme/tokens.ts # packages/docs/src/styles/yellow-theme/_variables.scss # packages/docs/src/styles/yellow-theme/css-tokens.css # packages/docs/src/styles/yellow-theme/tokens.ts # packages/mosaic-dev/toast/module.ts # packages/mosaic-dev/toast/template.html # packages/mosaic/design-tokens/legacy-2017/_variables.scss # packages/mosaic/design-tokens/legacy-2017/css-tokens.css # packages/mosaic/design-tokens/legacy-2017/tokens/components/checkbox.json5 # packages/mosaic/design-tokens/legacy-2017/tokens/components/navbar.json5 # packages/mosaic/design-tokens/legacy-2017/tokens/components/tags.json5 # packages/mosaic/design-tokens/tokens.ts # packages/mosaic/toast/toast-container.component.ts # packages/mosaic/toast/toast.component.html # packages/mosaic/toast/toast.component.scss # packages/mosaic/toast/toast.component.ts # packages/mosaic/toast/toast.module.ts # packages/mosaic/toast/toast.service.ts # packages/mosaic/toast/toast.type.ts
lskramarov
changed the title
Contributor
|
Preview docs changes for b516a86 at https://positive-js.github.io/mosaic-previews/pr731-b516a86/ |
Contributor
|
@agalaktionov нужен список токенов или хотя бы примерное понимание какие параметры мы собираемся настраивать через токены. Так же обрати внимание на анимацию, возможно ее тоже нужно будет подправить. |
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
Preview docs changes for 57a1695 at https://positive-js.github.io/mosaic-previews/pr731-57a1695/ |
lskramarov
changed the title
pimenovoleg
reviewed
Feb 14, 2022
|
|
||
| export type McToastStyle = 'default' | 'confirm' | 'custom' | 'success' | 'error' | 'warning' | 'info'; | ||
| export enum McToastPosition { | ||
| TOP_RIGHT = 'top-right', |
Member
There was a problem hiding this comment.
@lskramarov возможно использовать позиции, которые использовались в popover?
Contributor
@lskramarov гайд по тостам пока в работе, можно ли по временить пока с параметрами для токенов? |
Member
|
@vladimirverbitski синхронизируй с master веткой |
Contributor
Author
сделано |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.