-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add FontAwesome icons to section headings #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Welcome! Looks like this is your first pull request.
Hey, thanks for your contribution! Please give us a bit of time to review it. 😄
| % SECTION TITLE | ||
| %------------------------------------------------------------------------------- | ||
| \cvsection{Education} | ||
| \cvsection[\faGraduationCap]{Education} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the rendered example pdf if modifying here
| \ifempty{#1}{ | ||
| \sectionstyle{#2} | ||
| }{ | ||
| \sectioniconstyle{#2}{#1} | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest wrapping it all in \BeginAccSupp{ActualText={#2}} ... \EndAccSupp to avoid text conversion/ATS parsers seeing something like 'GRADUATION-CAP education'
Hi!
Great work with the CV! I noticed that using Font Awesome icons in the CV comes with some troubles. It doesn't look terribly well because the coloring of section headings depends on the number of characters. Thus, adding an icon and additional spacings breaks the actual coloring.
This PR adds an optional argument to CV sections that allows to define an additional text or icon to the beginning of the section title, without affecting the display of the actual title: