Skip to content

Conversation

@mcopik
Copy link

@mcopik mcopik commented Sep 8, 2023

Hi!

Great work with the CV! I noticed that using Font Awesome icons in the CV comes with some troubles. It doesn't look terribly well because the coloring of section headings depends on the number of characters. Thus, adding an icon and additional spacings breaks the actual coloring.

Screenshot from 2023-09-08 01-31-44

Screenshot from 2023-09-08 01-31-38

This PR adds an optional argument to CV sections that allows to define an additional text or icon to the beginning of the section title, without affecting the display of the actual title:

image

image

@github-actions github-actions bot added the size/XS Extra Small size issue or PR. label Sep 8, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Welcome! Looks like this is your first pull request.

Hey, thanks for your contribution! Please give us a bit of time to review it. 😄

% SECTION TITLE
%-------------------------------------------------------------------------------
\cvsection{Education}
\cvsection[\faGraduationCap]{Education}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the rendered example pdf if modifying here

Comment on lines +632 to +636
\ifempty{#1}{
\sectionstyle{#2}
}{
\sectioniconstyle{#2}{#1}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest wrapping it all in \BeginAccSupp{ActualText={#2}} ... \EndAccSupp to avoid text conversion/ATS parsers seeing something like 'GRADUATION-CAP education'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra Small size issue or PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants