Skip to content

Use command ls, in case ls is an alias #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2021
Merged

Use command ls, in case ls is an alias #406

merged 1 commit into from
Feb 3, 2021

Conversation

benjamineskola
Copy link
Contributor

This is perhaps an edgecase, but if ls is an alias/function it's possible that the output is not as expected, leading to failures.

@havenwood
Copy link
Collaborator

This would resolve #413.

@ktchen14 ktchen14 mentioned this pull request Nov 13, 2019
Closed
@FranklinYu
Copy link
Contributor

See also #424.

@FranklinYu FranklinYu mentioned this pull request Aug 30, 2020
Open
@FranklinYu FranklinYu mentioned this pull request Oct 13, 2020
Closed
@postmodern postmodern merged commit eda0818 into postmodern:master Feb 3, 2021
@postmodern
Copy link
Owner

Manually reviewed and merged even though CI is currently broken.

@postmodern postmodern self-requested a review February 3, 2021 05:31
@postmodern postmodern self-assigned this Feb 3, 2021
@JaKXz JaKXz mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postmodern postmodern Awaiting requested review from postmodern

Assignees

@postmodern postmodern

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjamineskola @havenwood @FranklinYu @postmodern