Skip to content

fix: recover retryable reviewer timeouts#229

Merged
mrcfps merged 2 commits intomainfrom
looper/221-reviewer-retryable-agent-timeo-eb193bf1cc234b5b
May 6, 2026
Merged

fix: recover retryable reviewer timeouts#229
mrcfps merged 2 commits intomainfrom
looper/221-reviewer-retryable-agent-timeo-eb193bf1cc234b5b

Conversation

@mrcfps
Copy link
Copy Markdown
Contributor

@mrcfps mrcfps commented May 6, 2026

Summary

  • Recover failed reviewer loops whose latest queue failure is retryable_transient while queue attempts remain.
  • Preserve the queue attempt count when requeueing these stranded retryable failures so recovery does not expand the configured retry budget.
  • Add reviewer, runtime, and storage coverage for retryable transient recovery and attempt preservation.

Validation

  • go test ./internal/reviewer ./internal/runtime ./internal/storage
  • GOCACHE=/tmp/looper-go-cache go test ./internal/agent
  • GOCACHE=/tmp/looper-go-cache go vet ./...
  • GOCACHE=/tmp/looper-go-cache go build ./...

GOCACHE=/tmp/looper-go-cache go test ./... was attempted, but this sandbox blocks local httptest port binding and reports the default ~/.looper/worktrees path as non-writable in config tests.

Closes #221

Generated by Looper 0.6.0 · runner=worker · agent=codex

Generated-By: looper 0.6.0 (runner=worker, agent=codex)
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c57f00927f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/reviewer/runner.go Outdated
Comment thread internal/runtime/runtime.go Outdated
@mrcfps
Copy link
Copy Markdown
Contributor Author

mrcfps commented May 6, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c57f00927f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/reviewer/runner.go Outdated
@mrcfps mrcfps merged commit 1e9494d into main May 6, 2026
1 check passed
@mrcfps mrcfps deleted the looper/221-reviewer-retryable-agent-timeo-eb193bf1cc234b5b branch May 6, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reviewer: retryable agent timeouts stop after three failures despite higher queue retry budget

1 participant