Add switch actions in Fast DC Security Analysis#1153
Merged
vidaldid-rte merged 76 commits intomainfrom May 21, 2025
Merged
Conversation
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
…ngine Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
…rrent tap Signed-off-by: p-arvy <pierre.arvy@artelys.com>
# Conflicts: # src/main/java/com/powsybl/openloadflow/dc/fastdc/WoodburyEngine.java # src/main/java/com/powsybl/openloadflow/sa/WoodburyDcSecurityAnalysis.java
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
This comment was marked as resolved.
This comment was marked as resolved.
|
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
src/main/java/com/powsybl/openloadflow/dc/fastdc/ConnectivityBreakAnalysis.java
Outdated
Show resolved
Hide resolved
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
Hadrien-Godard
previously approved these changes
Apr 15, 2025
vidaldid-rte
reviewed
May 2, 2025
src/test/java/com/powsybl/openloadflow/sa/WoodburyDcSecurityAnalysisWithActionsTest.java
Outdated
Show resolved
Hide resolved
vidaldid-rte
reviewed
May 2, 2025
src/main/java/com/powsybl/openloadflow/dc/fastdc/ComputedSwitchBranchElement.java
Show resolved
Hide resolved
vidaldid-rte
reviewed
May 2, 2025
src/main/java/com/powsybl/openloadflow/dc/fastdc/ComputedSwitchBranchElement.java
Outdated
Show resolved
Hide resolved
vidaldid-rte
reviewed
May 2, 2025
src/main/java/com/powsybl/openloadflow/dc/fastdc/ConnectivityBreakAnalysis.java
Outdated
Show resolved
Hide resolved
vidaldid-rte
reviewed
May 2, 2025
src/main/java/com/powsybl/openloadflow/dc/fastdc/AbstractComputedElement.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
vidaldid-rte
reviewed
May 9, 2025
| /** | ||
| * Returns true if the given contingency and operator strategy actions potentially break connectivity. | ||
| * This is determined with a "worst case" sensitivity-criterion. If the criterion is not verified, there is no connectivity break. | ||
| */ |
Collaborator
There was a problem hiding this comment.
What is exactly this "worst-case" sensitivity criterion ? I'm not sure what is meant here.
Collaborator
There was a problem hiding this comment.
Do you mean that isGroupOfElementsBreakingConnectivity is a heuristic that may return true when connectivity is not acutally broken, and to minimize this risk you should not provide switches that are going to be open ?
Member
There was a problem hiding this comment.
It means that if the criterion is verified then there might be a connectivity break. If it is not verified then we are sure there is no connectivity break. It is a conservative approach. @p-arvy , if I am wrong on this point, correct me.
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
Hadrien-Godard
previously approved these changes
May 12, 2025
|
Hadrien-Godard
approved these changes
May 20, 2025
vidaldid-rte
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: