Fix reported ignored target V and perform inconsistent target V checks#1362
Open
Fix reported ignored target V and perform inconsistent target V checks#1362
Conversation
Signed-off-by: Sharyal Zafar <sharyal.zafar@artelys.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No.
What kind of change does this PR introduce?
A bugfix and a modification in selected generator target V reporting logic.
What is the current behavior?
At the moment, when two generators are connected to different buses but regulating on the same bus, then the target voltage of the rejected (second) controller bus is reported as kept here. The GeneratorVoltageControl contains the earlier set target voltage value, which is logged as ignored here. Furthermore, in this unit test, 413 is expected as the target voltage value, whereas in the report 413.0 is reported as ignored.
Also, in the checkAndCreateVoltageControl method, unique target voltage check is never done if there are incosistent controlled buses. However, it is possible that a subset of the generators connected at the same bus is performing regulation at the same bus but with different target voltages. The information regarding which target voltage is kept is not logged at the moment.
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: