BBcode [right] align

[someonecantcode]

supersedes #12431
resolves #12356

in #12431, kama talks about rewriting the <center> implementation since it is deprecated but i don't know if i should do something about it. Quick question, if this gets merged, should i update the documentation in https://github.com/ppy/osu-wiki/blob/master/wiki/BBCode/en.md ?

Tested for main audio, spoilerboxes, videos results:

[peppy]

Also seen in #12431.

[LiquidPL]

the box/spoilerbox header can get left aligned when open

[LiquidPL]

this should probably reference .bbcode-spoilerbox instead.

[someonecantcode]

the box/spoilerbox header can get left aligned when open

hello im not sure what you meant by "header can get left aligned when open"? I wasn't able to recreate what you said.

[right][box=NAME]
text
[/box][/right]

[right][spoilerbox]text[/spoilerbox][/right]



[spoilerbox]text[/spoilerbox]

[spoilerbox][right]text[/right][/spoilerbox]

Anyways, yeah thanks for the catch on the .js-spoilerbox; I changed it to .bbcode-spoilerbox instead and works the same. I will rebase and squash in a moment.

[LiquidPL]

It happens specifically when you put a long, multiline paragraph of text in there, as you can see on my screenshot I've thrown a bunch of lorem ipsum into the spoilerbox.

[someonecantcode]

alright sweet. ty for quick reply/review and the multiline paragraph catch. hopefully that should cover everything.
happy new year!

i did a thorough testing and bbcode for the image:

[right] [spoilerbox] Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.[/spoilerbox] [/right]


[right]   [size=500][color=#FFFF00]Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.[/color] [/size] [/right]

[right] [box=HELLO]Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. [/box]  [/right]

[right] [img] https://tse3.mm.bing.net/th/id/OIP.MGuUDeuRuJE_cZjeMN_EGQHaHa?rs=1&pid=ImgDetMain&o=7&rm=3 [/img] [/right]

[right] [youtube]HjyYDrtYFZE[/youtube] [audio]https://www.onlinemictest.com/wp-content/themes/onlinemictest/sound.mp3[/audio] [/right]

[right] [notice]
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
[/notice][/right]

[nanaya]

I think making a bunch of those elements inline instead would work better. And [center] inside of [right] should have the expected effect (same with the other way)

[someonecantcode]

I think making a bunch of those elements inline instead would work better. And [center] inside of [right] should have the expected effect (same with the other way)

sorry im kinda confused and lost on what exactly needs to be changed.

For the nested behavior, are you saying [centre][right] text or whatever[ /right][/centre] and [right][centre] text or whatever[ /centre][/right] should be the same behavior? im not sure what the expected behavior should be for nested formatting. thanks.

[nanaya]

it should be whatever the last/current one is