Refactor slider-aim variable names and comments#36481
Open
Givikap120 wants to merge 4 commits intoppy:pp-devfrom
Open
Refactor slider-aim variable names and comments#36481Givikap120 wants to merge 4 commits intoppy:pp-devfrom
Givikap120 wants to merge 4 commits intoppy:pp-devfrom
Conversation
peppy
added
code quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
LazyTravelDistanceandLazyTravelTimewere renamed toBaseTravelDistanceandBaseTravelTimebecause normalTravelDistanceandTravelTimeare "Lazy" as well, but they don't have "Lazy" in the name, what can cause confusion.TravelDistanceandTravelTimenow reuse the comment from their "Lazy" (now "Base") analogs, but with clarification what exactly was changed:TravelDistanceincludes repeat slider bonus, whenTravelTimeis scaled by clockrate and capped to 25ms.MinimalJumpTimewas renamed to theLazyJumpTime, and comment was adjusted accordingly. As this time has nothing to do withMinimalJumpDistance. Instead - it's the time to doLazyJumpDistance, so essentially justAdjustedDeltaTime - TravelTime.MinimalJumpDistancewas removed and replaced with more technical one that explains what exactly it's doing and how it's different fromLazyJumpDistance.