scores set on custom rulesets should be deletable#36605
Open
voidstar0 wants to merge 6 commits intoppy:masterfrom
Open
scores set on custom rulesets should be deletable#36605voidstar0 wants to merge 6 commits intoppy:masterfrom
voidstar0 wants to merge 6 commits intoppy:masterfrom
Conversation
Contributor
Author
|
oops! apologies and thanks for catching this. I updated the code to check if the score was set by the local player || files > 0. (hopefully this is the correct approach!) also included a test 😺 fixed2.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #36596
A bug exists where scores saved on custom rulesets cannot be deleted. This is because custom rulesets cause
IsLegacyRulesetto return false, thus, the legacy replay reader does not engage and theFilesattribute on the score does not get incremented (and thus the Delete button is hidden).This PR introduces a change to always show the Delete button regardless.
I also wrote a test for this case :-)
fixed.mp4