Skip to content

scores set on custom rulesets should be deletable#36605

Open
voidstar0 wants to merge 6 commits intoppy:masterfrom
voidstar0:deletable-custom-ruleset-replays
Open

scores set on custom rulesets should be deletable#36605
voidstar0 wants to merge 6 commits intoppy:masterfrom
voidstar0:deletable-custom-ruleset-replays

Conversation

@voidstar0
Copy link
Contributor

Fixes #36596

A bug exists where scores saved on custom rulesets cannot be deleted. This is because custom rulesets cause IsLegacyRuleset to return false, thus, the legacy replay reader does not engage and the Files attribute on the score does not get incremented (and thus the Delete button is hidden).

This PR introduces a change to always show the Delete button regardless.

I also wrote a test for this case :-)

fixed.mp4

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes the delete context menu option to show on online leaderboards. When clicked, it does nothing.

Image

@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 7, 2026
@voidstar0
Copy link
Contributor Author

oops! apologies and thanks for catching this.

I updated the code to check if the score was set by the local player || files > 0. (hopefully this is the correct approach!)

also included a test 😺

fixed2.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replays saved while using custom rulesets cannot be deleted

2 participants