Fall hub connections back to non-websocket transports if websocket persistently fails#36617
Draft
bdach wants to merge 4 commits intoppy:masterfrom
Draft
Fall hub connections back to non-websocket transports if websocket persistently fails#36617bdach wants to merge 4 commits intoppy:masterfrom
bdach wants to merge 4 commits intoppy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a theoretical scenario wherein client & server go through transport negotiation, agree to use websockets, but then websockets get killed persistently but other transports might not be getting killed persistently, this theoretically maybe allows said users to connect to spectator server.
I've only vaguely tested that this vaguely does what I wrote above. I don't know whether this diff is going to help a single user. Would need users currently affected by spectator server blocks to test and say.