Add no-stdlib build for mlkem-native #1153
Conversation
willieyz
force-pushed
the
add-no-stdlib-build
branch
3 times, most recently
from
4fdf64b to
2e4aaaa
Compare
There was a problem hiding this comment.
This README still needs to be adjusted
There was a problem hiding this comment.
Yes, thanks for the reminder!
I have addressed this and re-pushed the changes,
including
examples/README.md,examples/multilevel_build_no_stdlib/README.mdmlkem/README.md
and also added this example to base.yml for the CI tests.
willieyz
force-pushed
the
add-no-stdlib-build
branch
4 times, most recently
from
faec912 to
cebb880
Compare
examples/README.md
Outdated
| with `-nostdlib` flag, the `mlk_memcpy` and `mlk_memset` are replaced by custom implementation. | ||
| in such a way that level-independent code with no stadard libary is shared. |
There was a problem hiding this comment.
Please fix the grammar
There was a problem hiding this comment.
Hello Hanno, thank you for reviewing!
I have addressed the grammar issue and also restructured the explanation in what I believe is a better format.
I know this README is intended for users and serves as a formal document,
please feel free to let me know if there is anything you find inappropriate. I will make the adjustments until it meets expectations.
| -Wno-unknown-pragmas \ | ||
| -Wno-unused-command-line-argument \ | ||
| -fomit-frame-pointer \ | ||
| -DMLK_CONFIG_NAMESPACE_PREFIX=mlkem \ |
There was a problem hiding this comment.
Hello Hanno, thank you for reviewing!
I have addressed the indentation issue.
Additionally, since this Makefile is based on examples/multilevel_build/Makefile, and the same indentation issue appeared there as well, I have fixed it too.
willieyz
force-pushed
the
add-no-stdlib-build
branch
4 times, most recently
from
709a22c to
abfc2dc
Compare
willieyz
force-pushed
the
add-no-stdlib-build
branch
from
abfc2dc to
b9ee08d
Compare
willieyz
force-pushed
the
add-no-stdlib-build
branch
from
b9ee08d to
37163aa
Compare
- This commit add an example demonstrating how to build mlkem-native without the standard library (-nostdlib) - Create an example folder named `multilevel_build_no_stdlib` - Add the `example_no_stdlib_config.h` reference from `test/custom_stdlib_config.h`, this config provide custom implementations for mlk_memcpy and mlk_memset - Add the `-nostdlib` cflag during generating objects file. - Integrate this example to the `tests` script and ./Makefile - Add this example to the `base.yml` for CI testing Signed-off-by: willieyz <[email protected]>
willieyz
force-pushed
the
add-no-stdlib-build
branch
from
37163aa to
e847379
Compare
-nostdlib)multilevel_build_no_stdlibexample_no_stdlib_config.hreference fromtest/custom_stdlib_config.h,this config file provide custom implementations for
mlk_memcpyandmlk_memset-nostdlibcflag during generating objects file.testsscript and./Makefile