Add no-stdlib build for mlkem-native #1153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willieyz
force-pushed
the
add-no-stdlib-build
branch
3 times, most recently
from
4fdf64b to
2e4aaaa
Compare
There was a problem hiding this comment.
This README still needs to be adjusted
There was a problem hiding this comment.
Yes, thanks for the reminder!
I have addressed this and re-pushed the changes,
including
examples/README.md,examples/multilevel_build_no_stdlib/README.mdmlkem/README.md
and also added this example to base.yml for the CI tests.
willieyz
force-pushed
the
add-no-stdlib-build
branch
4 times, most recently
from
faec912 to
cebb880
Compare
willieyz
force-pushed
the
add-no-stdlib-build
branch
4 times, most recently
from
709a22c to
abfc2dc
Compare
willieyz
force-pushed
the
add-no-stdlib-build
branch
from
abfc2dc to
b9ee08d
Compare
willieyz
force-pushed
the
add-no-stdlib-build
branch
2 times, most recently
from
37163aa to
e847379
Compare
mkannwischer
requested changes
Sep 17, 2025
There was a problem hiding this comment.
I am fine with the changes now (except for a small nit), but this PR conflicts with #1185. Please rebase on top of that one.
willieyz
force-pushed
the
add-no-stdlib-build
branch
5 times, most recently
from
309dd25 to
4c8e5be
Compare
mkannwischer
requested changes
Sep 18, 2025
willieyz
force-pushed
the
add-no-stdlib-build
branch
2 times, most recently
from
e3adae2 to
e1f2117
Compare
mkannwischer
requested changes
Sep 18, 2025
There was a problem hiding this comment.
Thanks @willieyz. I am fine with the code changes now.
I found a small typo in the READMEs that was pre-existing before your PR, but maybe we can sort that out in a separate commit everywhere?
willieyz
added a commit
that referenced
this pull request
Sep 18, 2025
…2/768/1024}` - This typo was pre-existing before this PR #1153, we sort this out with a separate commit Signed-off-by: willieyz <[email protected]>
willieyz
force-pushed
the
add-no-stdlib-build
branch
from
e1f2117 to
243b0af
Compare
mkannwischer
requested changes
Sep 19, 2025
There was a problem hiding this comment.
Small correction of the grammar. Then this is good to go.
Thanks @willieyz!
willieyz
added a commit
that referenced
this pull request
Sep 19, 2025
…2/768/1024}` - This typo was pre-existing before this PR #1153, we sort this out with a separate commit Signed-off-by: willieyz <[email protected]>
willieyz
force-pushed
the
add-no-stdlib-build
branch
from
243b0af to
707fa9a
Compare
mkannwischer
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Thanks @willieyz. I'm happy with this PR now.
@hanno-becker - what do you think? Note that the second commit (renaming) is somewhat unrelated and requested by me.
willieyz
added a commit
that referenced
this pull request
Sep 24, 2025
…2/768/1024}` - This typo was pre-existing before this PR #1153, we sort this out with a separate commit Signed-off-by: willieyz <[email protected]>
willieyz
force-pushed
the
add-no-stdlib-build
branch
from
707fa9a to
6af5c38
Compare
- This commit add an example demonstrating how to build mlkem-native without the standard library (-nostdlib) - Create an example folder named `multilevel_build_no_stdlib` - Add the `example_no_stdlib_config.h` reference from `test/custom_stdlib_config.h`, this config provide custom implementations for mlk_memcpy and mlk_memset - Add the `-nostdlib` cflag during generating objects file. - Integrate this example to the `tests` script and ./Makefile - Add this example to the `base.yml` for CI testing Signed-off-by: willieyz <[email protected]>
…2/768/1024}` - This typo was pre-existing before this PR #1153, we sort this out with a separate commit Signed-off-by: willieyz <[email protected]>
willieyz
force-pushed
the
add-no-stdlib-build
branch
from
6af5c38 to
208fe20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-nostdlib)multilevel_build_no_stdlibexample_no_stdlib_config.hreference fromtest/custom_stdlib_config.h,this config file provide custom implementations for
mlk_memcpyandmlk_memset-nostdlibcflag during generating objects file.testsscript and./Makefile