Makefile: track environment variable changes #1260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only values variables passed as Makefile variables (make VAR=value) triggered rebuilds when changed. Now environment variables (VAR=value make) are also tracked. rf.: pq-code-package#1150 Signed-off-by: Andreas Hatziiliou <[email protected]>
L-series
force-pushed
the
track_env_vars
branch
from
c53b96e to
d23b9d7
Compare
|
@L-series Thank you for this PR! We currently only accept contributions from people we know. Would you mind reaching out to us on Discord or via e-mail for an introduction? |
|
Of course! I just sent you a message on discord. @hanno-becker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality in which buils will now also be retriggered by changes to environment vairables.
Changes
Why:
Previously
VAR=VAL makewouldn't trigger rebuild, butmake VAR=VALwould. Now both are properly detected."rf.: #1150