Skip to content

Conversation

@willieyz
Copy link
Contributor

@willieyz willieyz commented Oct 30, 2025

- This commit ported from mldsa-native PR #568
- This commit fixes an issue where the dry_run argument was not working
  in the gen_bib_file() function. As a result, the CI would not raise an
  error when BIBLIOGRAPHY.md was missing updates.

- The problem was that the dry_run parameter was always set to False,
  so the dry-run mode was never enabled during execution.

Signed-off-by: willieyz <[email protected]>
@mkannwischer mkannwischer marked this pull request as ready for review October 30, 2025 09:01
@mkannwischer mkannwischer requested a review from a team as a code owner October 30, 2025 09:01
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @willieyz!

@mkannwischer mkannwischer changed the title autogen: fix incorrect dry_run handling in gen_bib_file() Linting: Detect outdated BIBLIOGRAPHY.md Oct 31, 2025
@mkannwischer mkannwischer merged commit c318c61 into main Oct 31, 2025
386 checks passed
@mkannwischer mkannwischer deleted the fix-autogen-gen_bib_file branch October 31, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants