fix(cli): wire --rules/--rules-include/--rules-exclude/--ruleset into github and gitlab cmds#220
Conversation
These args were only registered on `titus scan`, so `titus github` and `titus gitlab` always loaded builtins with the default ruleset and ignored custom rules. This binds the existing scan globals to both cmds (and their `scan` subcmds) and passes them through to loadRules so custom rules merge with builtins as documented.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Hey @n0kovo, thanks for taking the time to submit this PR! Our team has been notified and someone will be picking this up shortly. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe change adds configurable rule loading to GitHub and GitLab scanning commands. Four new CLI flags ( ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
michaelweber
left a comment
michaelweber
left a comment
There was a problem hiding this comment.
Good catch. I feel we're probably using the flags wrong if we need to do this for every command, but I'll leave that for a future refactor. Let's remove the pain point right away. Thanks for the PR!
|
Hey @n0kovo, this should now be resolved. If everything looks good on your end, no action needed. If you're still seeing issues, feel free to reopen and we'll take another look. Thanks for helping us improve! |
The flag was registered on githubScanCmd and gitlabScanCmd but missing from the legacy root invocation path (githubCmd / gitlabCmd), which already had the four --rules* flags from #220. Adds flag parity.
2 participants
These flags were only registered on
titus scan, sotitus githubandtitus gitlabalways loaded builtins with the default ruleset and ignored custom rules. This binds the existing scan globals to both cmds (and theirscansubcmds) and passes them through to loadRules so custom rules merge with builtins as documented.complements #218: that PR fixes how
--rulesparses input; this one exposes the flag ongithub/gitlabcmds.