fix: Avoid Trusted Types violation when dangerouslySetInnerHTML is re…#4935
Open
lukewarlow wants to merge 1 commit intopreactjs:mainfrom
Open
fix: Avoid Trusted Types violation when dangerouslySetInnerHTML is re…#4935lukewarlow wants to merge 1 commit intopreactjs:mainfrom
lukewarlow wants to merge 1 commit intopreactjs:mainfrom
Conversation
…moved Setting innerHTML to an empty string violates Trusted Types. This changes to using textContent tp empty element children.
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
Contributor
Author
|
No new test because tests such as 'should apply proper mutation for VNodes with dangerouslySetInnerHTML attr' already cover this (if you change the empty string to 'foo' for example it fails. |
| newVNode._children = []; | ||
| } else { | ||
| if (oldHtml) dom.innerHTML = ''; | ||
| if (oldHtml) dom.textContent = ''; |
Member
There was a problem hiding this comment.
I'd prefer to have a test for the trusted HTML case if that's possible at all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…moved
Setting innerHTML to an empty string violates Trusted Types. This changes to using textContent tp empty element children.
Fixes #4934