Merged
Conversation
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: +70 B (+0.09%) Total Size: 78.8 kB
ℹ️ View Unchanged
|
JoviDeCroock
force-pushed
the
remove-act-leak-in-core
branch
from
3d98a77 to
db2c2fc
Compare
JoviDeCroock
changed the title
JoviDeCroock
requested review from
andrewiggins,
developit and
marvinhagemeister
JoviDeCroock
commented
Feb 12, 2026
JoviDeCroock
force-pushed
the
remove-act-leak-in-core
branch
from
069a131 to
b81c0c4
Compare
JoviDeCroock
commented
Feb 16, 2026
| renderComponent(c); | ||
| } | ||
| } finally { | ||
| rerenderQueue.length = process._rerenderCount = 0; |
Member
Author
There was a problem hiding this comment.
This is up for debate, we could also just wrap renderComponent in this try {} catch {} and throw the first error so that we do process the rest of the queue
marvinhagemeister
approved these changes
Feb 17, 2026
Merged
JoviDeCroock
added a commit
that referenced
this pull request
Mar 10, 2026
* Golf some bytes and ensure we reset renderCount * Apply suggestion from @JoviDeCroock * Add test (cherry picked from commit 55254ef)
JoviDeCroock
added a commit
that referenced
this pull request
Mar 15, 2026
* Fix crash where a synchronous effect render unmounts the tree (#5026) (cherry picked from commit 8cbed5f) * Golf down compat (#5025) * Make useFlushSync do sync flushes * Golf bytes to offset change * Some more golfing * Revert "Make useFlushSync do sync flushes" This reverts commit 001bbce. (cherry picked from commit af4c459) * Implement flushSync (#5036) (cherry picked from commit 978c0b9) * undefined prototype (#5041) * undefined prototype * Add test (cherry picked from commit b341bfe) * Ensure we reset renderCount (#5017) * Golf some bytes and ensure we reset renderCount * Apply suggestion from @JoviDeCroock * Add test (cherry picked from commit 55254ef) * fix(compat): export StrictMode directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently due to the condition ofprevDebounce != options.debounceRenderingwe leak an implementation detail ofactin our general implementation. We don't want this so we're just exposingprocessonoptionsto avoid us having to account for this in the future. When our consumers overrideoptions.debounceRenderingthey might accidentally introduce more renders than intended when is about to be processed.The above did not work out, we should encourage people to override
options.debounceRenderingbefore scheduling any preact updates which should entirely bypass the possiblity of thisAnother issue we had was that if
process()would throw without any resolution in the component tree thatprocess._rerenderCountwould never return back to 0 and hence stop any future render from being scheduled. This is handled in thetry finallyblock.I've also added a byte saving opportunity with pushing the
component._dirtycheck down a bit.Resolves #5002