feat: add support for dangerouslySetInnerHTML on Fragments#5057
Open
marvinhagemeister wants to merge 4 commits intov10.xfrom
Open
feat: add support for dangerouslySetInnerHTML on Fragments#5057marvinhagemeister wants to merge 4 commits intov10.xfrom
dangerouslySetInnerHTML on Fragments#5057marvinhagemeister wants to merge 4 commits intov10.xfrom
Conversation
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: +2.47 kB (+3.13%) Total Size: 81.2 kB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting
dangerouslySetInnerHTMLon Fragments. It allows you to inject raw unsafe HTML without a container element. This is useful for styling through CSS like with grids or flexbox which are sensitive to child elements.Before:
After:
This is the client-side equivalent of preactjs/preact-render-to-string#453
Given the size increase I'm not sure if we want to land this, but seems useful enough. Long-term we could make the byte increase worth it by generalizing the concept of a "virtual element between markers" for suspense, streaming, etc. That would make the size increase more worth it.