-
-
Notifications
You must be signed in to change notification settings - Fork 210
Hotfix v3.3.1 #2429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix v3.3.1 #2429
Conversation
Co-authored-by: Frédéric Simonis <[email protected]>
Co-authored-by: Frédéric Simonis <[email protected]>
…nt type in the if constexpr branch
* Fix unsigned int logging * Changelog entry
5c4b26a to
5f82c8a
Compare
|
MinGW UCRT Debug fails for the same reason we disabled it on develop. Apart from that, the hotfix is ready for review. |
If this is known to fail and it is anyway something that is not a regression (but something we want to support as well at some point), does it make sense disabling it in this release? Otherwise, the |
5f82c8a to
af02a06
Compare
True. I cherry-picked it to the hotfix. |
|
I re-triggered the systemtest and will wait for @IshaanDesai to approve as he requires the hotfix. |
IshaanDesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran a two-scale simulation with the Micro Manager and the hotfix, and can confirm that nested events work as expected.
|
Website: versions bumped in:
Not a time to update the Roadmap (bugfix release, and the Roadmap needs more discussion anyway). |
|
Posted on Mastodon and Bluesky. @fsimonis posted on Matrix. I don't think we need to post anywhere else for this release. |
How to work with this template
@member.Only the release manager should update this post (even tickboxes, due to race conditions in editing). Everybody else should comment on the PR with the progress.
Pre-PR steps
mainbranch locally.hotfix-vX.Y.Zfrommain. If needed,git rebase main.pre-commit run -va).github/workflows/release.ymltools/releasing/bumpversion.sh MAJOR.MINOR.PATCHto bump the versionCHANGELOG.mdof the hotfix branch (all)CHANGELOGCMakeLists.txttools/releasing/packaging/debian/changelogStep by step guide
hotfix-vX.Y.Ztomain(use this template)trigger-system-testslabel (release_testsuite). After any force-push, remove and add the label again.git rebase -i mainmain( usegit merge --no-ff hotfix-vX.Y.Z)mainvX.Y.Zand verify by runninggit describe --tagsmainback todevelopand verify by runninggit describe --tagsgit reset --hard upstream BRANCHor by cloning the precice repository again and start from scratch.mainand thevX.Y.Ztag:git push upstream main,git push upstream v3.3.1develop:git push upstream developPost-release
_config.ymlbinprecice mdMarketing
See the advertising a workshop section for additional ideas.
Misc
To open a new PR with this template, use this PR template query