fix: physics should be required explicitly#118
Merged
Conversation
fdalcin
approved these changes
Apr 1, 2025
fdalcin
left a comment
fdalcin
left a comment
There was a problem hiding this comment.
LGTM, tested locally and it works as described
fdalcin
pushed a commit
that referenced
this pull request
Jul 2, 2025
* fix: remove unneeded temporary deploy meta data * fix: remove unneeded deploy meta data * feat: mathjax-3 (#103) * feat: mathjax-3 * physics wip * wip add test cases * wip add gh action * add matrix test and handle htmlentities * strip require and improve tests * feat: base 64 formulas support (#113) * feat: base 64 formulas support * different test for gh * gh approach * fix asciimath parameters * remove console * mathml with base64 * chore: add claudia deploy instruction to use linux dependencies (#114) * chore: add claudia deploy instruction to use linux dependencies * improve readme --------- Co-authored-by: Oscar Arzola <oscararzola@gmail.com> * fix: physics should be required explicitly (#118) * improve tests * improve tests * remove log * remove log * remove log * fix: percent symbol formulas (#132) * fix: mathml % formulas (#137) * chore: remove dependabot in production since it is used in dev only chore: update claudia.json to use production --------- Co-authored-by: Christopher Murtagh <christopher@pressbooks.com> Co-authored-by: Oscar Arzola <oscararzola@gmail.com>
ho-man-chan
added a commit
that referenced
this pull request
Jan 15, 2026
* fix: remove unneeded temporary deploy meta data * fix: remove unneeded deploy meta data * feat: mathjax-3 (#103) * feat: mathjax-3 * physics wip * wip add test cases * wip add gh action * add matrix test and handle htmlentities * strip require and improve tests * feat: base 64 formulas support (#113) * feat: base 64 formulas support * different test for gh * gh approach * fix asciimath parameters * remove console * mathml with base64 * chore: add claudia deploy instruction to use linux dependencies (#114) * chore: add claudia deploy instruction to use linux dependencies * improve readme --------- Co-authored-by: Oscar Arzola <oscararzola@gmail.com> * fix: physics should be required explicitly (#118) * improve tests * improve tests * remove log * remove log * remove log * fix: percent symbol formulas (#132) * fix: mathml % formulas (#137) * fix: mathml % on other tags (#139) * fix: mathml % on other tags * non optional * non optional * feat: add automated deploy pipeline in aws (#142) * feat: add release please for automated versioning and releases (#143) * feat: add Release Please for automated versioning and releases - Add release-please workflow with function.zip artifact on release - Add release-please config and manifest files - Update tests workflow to run on production branch - Update README with release process documentation - Remove obsolete claudia.json (replaced by CodePipeline) * docs: add CHANGELOG.md and link in README --------- Co-authored-by: Ho Man Chan <homan98@gmail.com> Co-authored-by: Christopher Murtagh <christopher@pressbooks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several updates to the
src/imageGenerator.jsfile and the test cases intest/latex.test.jsto enhance the LaTeX rendering functionality and improve test coverage. The most important changes include moving the TeX configuration inside thegeneratefunction, adding logging for decoded math, and updating the test cases to use base64 encoded LaTeX strings.#117
Enhancements to LaTeX rendering:
generatefunction to dynamically include the 'physics' package based on the input (src/imageGenerator.js).src/imageGenerator.js). [1] [2]Improvements to test coverage:
test/latex.test.js). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]test/latex.test.js).test/latex.test.js).