Make bytes available

[shangm2]

1. Make the bytes written to memory buffer available to outside world
2. Needed by Add support to provide thrift codec for connector specific fields presto#25242 and https://github.com/facebookexternal/presto-facebook/pull/3243

[shangm2]

This allows us to retrieve metadata for other classes.

[shangm2]

We need to retrieve the bytes because our serde is general and it returns bytes https://github.com/prestodb/presto/pull/25242/files#r2127315310

[arhimondr]

Consider creating a separate TMemoryBuffer implementation based on the ByteArrayOutputStream with only write method available. Consider using the more efficient ByteArrayOutputStream implementation from Guava.

[arhimondr]

Please extract the change adding the ThriftCatalog catalog into a separate commit

[shangm2]

I was trying to use the passed-in catalog to retrieve the metadata for fields within Split because I was manually building the metadata for split. I have updated the code to use annotation for split and custom codec for complicated field within it so we dont need to catalog anymore. My apology for the confusion.

[arhimondr]

Could you please explain what problem are you trying to solve? Why is it necessary to have access to ThriftCatalog to define a thrift type? Ideally this method should be pure constant / static.

[shangm2]

I was trying to use the passed-in catalog to retrieve the metadata for fields within Split because I was manually building the metadata for split. I have updated the code to use annotation for split and custom codec for complicated field within it so we dont need to catalog anymore. My apology for the confusion.

[arhimondr]

Consider creating a separate TMemoryBuffer implementation based on the ByteArrayOutputStream with only write method available. Consider using the more efficient ByteArrayOutputStream implementation from Guava.