-
Notifications
You must be signed in to change notification settings - Fork 17
Add NoRandomDuplicates feature for random query execution without duplicates #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8f566d0
to
de17b5f
Compare
Testing Procedure + Results
|
Change MergeWith function to support NoRandomDuplicates
4ec3af7
to
2c5ddb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plesee add documentation to https://github.com/prestodb/pbench/wiki/Parameters for your new flag
no_random_duplicates Documentation (Sent to Steve Burnett for editing)Format"no_random_duplicates": Boolean DefinitionWhen When This feature works by:
Use CasesThis feature is particularly useful for:
|
} | ||
|
||
// Initialize the bag with all available query indices | ||
var bag []int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not using a map?
This PR introduces a new configuration parameter
no_random_duplicates
that prevents duplicate query selection during random execution until all queries have been executed once.Changes:
- Queries are randomly selected and removed from a "bag" to prevent duplicates within each round
- When the bag is exhausted (all queries executed once), it automatically refills for subsequent rounds
Usage:
{ "random_execution": true, "randomly_execute_until": "10", "no_random_duplicates": true, "query_files": ["query1.sql", "query2.sql", "query3.sql"] }