Skip to content

Conversation

unidevel
Copy link
Contributor

The current release action only upload the artifacts, need to call the API to publish uploaded artifacts.

git checkout presto-maven-plugin-${{ env.RELEASE_VERSION }}
git ls -5
cat ~/.m2/settings.xml
mvn clean install
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run tests

Copy link

sourcery-ai bot commented Sep 19, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Split the release workflow into distinct upload and publish phases and add a curl-based call to the Sonatype OSSRH staging API to finalize artifact publication.

File-Level Changes

Change Details Files
Separate artifact deployment into explicit upload and publish steps
  • Rename 'Publish release' step to 'Upload artifacts'
  • Insert 'mvn clean install' prior to mvn deploy
  • Adjust step naming to reflect upload operation
.github/workflows/release.yml
Implement staging API call to publish artifacts
  • Encode Nexus credentials as base64 and mask the token
  • Invoke curl POST to OSSRH staging API endpoint for automatic publishing
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

- name: Publish artifacts
run: |
AUTH_TOKEN=$(echo -n "${NEXUS_USERNAME}:${NEXUS_PASSWORD}" | base64)
echo "::add-mask::${AUTH_TOKEN}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mask the token in logs

@unidevel unidevel self-assigned this Sep 19, 2025
@unidevel unidevel requested a review from pdabre12 September 19, 2025 06:03
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.github/workflows/release.yml:97-100` </location>
<code_context>

+      - name: Publish artifacts
+        run: |
+          AUTH_TOKEN=$(echo -n "${NEXUS_USERNAME}:${NEXUS_PASSWORD}" | base64)
+          echo "::add-mask::${AUTH_TOKEN}"
+          curl -v -X POST "https://ossrh-staging-api.central.sonatype.com/manual/upload/defaultRepository/com.facebook?publishing_type=automatic" \
+            -H "Authorization: Bearer ${AUTH_TOKEN}"
+
       - name: Push changes and tags
</code_context>

<issue_to_address>
**issue (bug_risk):** Review use of Bearer token for Sonatype API authentication.

Sonatype expects Basic authentication (base64-encoded username:password) rather than Bearer tokens. Please verify the required header format in the API documentation to avoid authentication issues.
</issue_to_address>

### Comment 2
<location> `.github/workflows/release.yml:96-100` </location>
<code_context>
+        run: |
+          AUTH_TOKEN=$(echo -n "${NEXUS_USERNAME}:${NEXUS_PASSWORD}" | base64)
+          echo "::add-mask::${AUTH_TOKEN}"
+          curl -v -X POST "https://ossrh-staging-api.central.sonatype.com/manual/upload/defaultRepository/com.facebook?publishing_type=automatic" \
+            -H "Authorization: Bearer ${AUTH_TOKEN}"
+
</code_context>

<issue_to_address>
**suggestion (bug_risk):** Consider error handling for the curl upload step.

Without error handling, a failed curl upload won't stop the workflow. Add 'set -e' or check the curl exit code to ensure the job fails on upload errors.

```suggestion
        run: |
          set -e
          AUTH_TOKEN=$(echo -n "${NEXUS_USERNAME}:${NEXUS_PASSWORD}" | base64)
          echo "::add-mask::${AUTH_TOKEN}"
          curl -v -X POST "https://ossrh-staging-api.central.sonatype.com/manual/upload/defaultRepository/com.facebook?publishing_type=automatic" \
            -H "Authorization: Bearer ${AUTH_TOKEN}"
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@unidevel unidevel requested a review from tdcmeehan September 19, 2025 06:03
@unidevel
Copy link
Contributor Author

We can leave this PR until next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant