-
Notifications
You must be signed in to change notification settings - Fork 5.5k
docs: Fix return type for ST_CoordDim #26355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR aligns the ST_CoordDim documentation with its Java implementation by updating the return type to tinyint in the Sphinx docs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a9c7ffd
to
cdb9b5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull branch, local doc build.
Thanks for the fix!
Description
Change the docs return type to ST_CoordDim
Motivation and Context
Match the docs with the java code for ST_CoorDim return type to be tinyint:
presto/presto-main-base/src/main/java/com/facebook/presto/geospatial/GeoFunctions.java
Line 340 in 1a4b462
related to: #26344
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.