Skip to content

Conversation

@PingLiuPing
Copy link
Contributor

@PingLiuPing PingLiuPing commented Oct 22, 2025

Description

Iceberg use GZIP as the default compression for parquet before version 1.4. See info here

And when iceberg connector was introduced to Presto, the version of Iceberg is 0.9.0. And hence it uses GZIP as the default compression codec at that time.

Now that Iceberg has changed the default compression codec to ZSTD. And the iceberg version in Presto has upgraded to 1.8.1. We should change the default compression codec to ZSTD to align with iceberg.

Moreover, from the performance test result I found that ZSTD has much better performance over GZIP. See results.

Motivation and Context

Impact

Test Plan

show session output:

Screenshot 2025-10-22 at 11 09 52

The actual data file metadata:

$ parquet-tools inspect 127dbe88-372d-4872-a00f-02669277732e.parquet

############ file meta data ############
created_by:
num_columns: 2
num_rows: 2
num_row_groups: 1
format_version: 1.0
serialized_size: 175

############ Columns ############
c1
c2

############ Column(c1) ############
name: c1
path: c1
max_definition_level: 1
max_repetition_level: 0
physical_type: INT32
logical_type: None
converted_type (legacy): NONE
compression: ZSTD (space_saved: -42%)

############ Column(c2) ############
name: c2
path: c2
max_definition_level: 1
max_repetition_level: 0
physical_type: INT64
logical_type: None
converted_type (legacy): NONE
compression: ZSTD (space_saved: -33%)

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Iceberg Connector Changes
* Replace default iceberg compression codec from GZIP to ZSTD.

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Oct 22, 2025
@prestodb-ci prestodb-ci requested review from a team, auden-woolfson and xin-zhang2 and removed request for a team October 22, 2025 10:11
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Iceberg connector’s default Parquet compression codec from GZIP to ZSTD to align with Iceberg 1.8.1’s new default and leverage its improved performance.

Class diagram for updated IcebergConfig compression codec

classDiagram
    class IcebergConfig {
        IcebergFileFormat fileFormat = PARQUET
        HiveCompressionCodec compressionCodec = ZSTD
        CatalogType catalogType = HIVE
        String catalogWarehouse
        String catalogWarehouseDataDir
    }
Loading

File-Level Changes

Change Details Files
Changed default compression codec for Iceberg
  • Initialize compressionCodec to ZSTD instead of GZIP
  • Update default config test to expect ZSTD
IcebergConfig.java
TestIcebergConfig.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@steveburnett
Copy link
Contributor

Please update the doc for the default of iceberg.compression-codec in https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/connector/iceberg.rst#configuration-properties.

@tdcmeehan tdcmeehan changed the title feat: Change iceberg default compression codec to ZSTD feat(plugin-iceberg): Change iceberg default compression codec to ZSTD Oct 22, 2025
Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change. The failure tests seems to be related.

@PingLiuPing
Copy link
Contributor Author

Thanks for this change. The failure tests seems to be related.

Yes, I'm checking.

@PingLiuPing PingLiuPing force-pushed the lp_default_iceberg_codec branch 2 times, most recently from 8edce0c to 6166e2e Compare October 22, 2025 16:16
@PingLiuPing
Copy link
Contributor Author

Please update the doc for the default of iceberg.compression-codec in https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/connector/iceberg.rst#configuration-properties.

Thanks.

@PingLiuPing PingLiuPing force-pushed the lp_default_iceberg_codec branch from 6166e2e to 03f4c3b Compare October 22, 2025 21:01
Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PingLiuPing

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

@PingLiuPing PingLiuPing merged commit 9a92259 into prestodb:master Oct 23, 2025
79 checks passed
@PingLiuPing PingLiuPing deleted the lp_default_iceberg_codec branch October 23, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants