Make codebase more friendly to modern ARM compilers#2271
Open
LumioseSil wants to merge 2 commits intopret:masterfrom
Open
Make codebase more friendly to modern ARM compilers#2271LumioseSil wants to merge 2 commits intopret:masterfrom
LumioseSil wants to merge 2 commits intopret:masterfrom
Conversation
LLVM whines over dumb things like no # before constants in asm and OAM_BUFFER because of the fastcopy thing.
So much type-punning causes things to not work on modern compilers. Additionally, -fno-toplevel-reorder is only needed for files with COMMON, as otherwise gcc will break this, so only have them for the two files that need it. Resulting rom tested on real hardware and mGBA.
Contributor
Author
|
Putting two commits here since both allow modern compilers like LLVM and latest GCC to compile this rom without issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM whines over dumb things like no # before constants in asm and OAM_BUFFER because of the fastcopy thing.