feat: add Docker build environment#2278
Open
GregTheGreek wants to merge 1 commit intopret:masterfrom
Open
Conversation
Ubuntu 24.04 container with ARM cross-compilation toolchain for building the ROM without host toolchain setup. Includes Makefile targets for docker-build, docker-shell, and docker-clean. Co-Authored-By: Claude
|
I did something similar to use podman to build the images. |
Author
|
Yeah i guess yours is more verbose as a full env vs just generating builds. I'd close this in favour depends what the team wants |
|
I just wanted the ability to build the ROM using agbcc, using agbcc+bugfixes, modern, and modern+bugfixes. I wouldn't know how to help combine this into this repo, I created a separate directory to hold those files. I hope I can help in any way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Main goal: Remove as many toolchain requirements for build/compilation.
Adds a docker env to reduce host machine toolchain requirements. The built rom outputs to the host machine (not persisted in the container).
Tested locally, and currently making mods with it. Roms are building and running as expected.
This does not remove the requirement for tools such as porymap, etc..
Discord contact info
gregthegreek