Skip to content

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Jul 30, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings July 30, 2025 02:52
@francinelucca francinelucca requested a review from a team as a code owner July 30, 2025 02:52
@francinelucca francinelucca requested a review from TylerJDev July 30, 2025 02:52
Copy link

changeset-bot bot commented Jul 30, 2025

⚠️ No Changeset found

Latest commit: acbe950

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all references to the css_modules_ga feature flag from the codebase, indicating that CSS modules functionality has been fully rolled out and the feature flag is no longer needed.

  • Removed the primer_react_css_modules_ga feature flag from the default configuration
  • Cleaned up the Storybook configuration to remove environment variable handling for the removed flag

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts Removed the primer_react_css_modules_ga feature flag entry
packages/react/.storybook/preview.jsx Removed PRIMER_REACT_CSS_MODULES_GA from the feature flag environment list
Comments suppressed due to low confidence (1)

packages/react/.storybook/preview.jsx:237

  • With an empty Set, the for loop on lines 236-237 will never execute. Consider removing this unused loop logic or adding a comment explaining why this structure is maintained for future feature flags.
const featureFlagEnvList = new Set([])

for (const flag of featureFlagEnvList) {
  if (import.meta.env[`VITE_${flag}`] === '1') {

@github-actions github-actions bot added the staff Author is a staff member label Jul 30, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 30, 2025
Copy link
Contributor

github-actions bot commented Jul 30, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.58 KB (+0.09% 🔺)
packages/react/dist/browser.umd.js 89.57 KB (-0.1% 🔽)

@francinelucca francinelucca added the skip changeset This change does not need a changelog label Jul 30, 2025
@francinelucca francinelucca added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit b5efef8 Jul 30, 2025
43 checks passed
@francinelucca francinelucca deleted the chore/remove-ff branch July 30, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants