-
Notifications
You must be signed in to change notification settings - Fork 625
chore: remove all references to css_moduels_ga FF in codebase #6415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes all references to the css_modules_ga
feature flag from the codebase, indicating that CSS modules functionality has been fully rolled out and the feature flag is no longer needed.
- Removed the
primer_react_css_modules_ga
feature flag from the default configuration - Cleaned up the Storybook configuration to remove environment variable handling for the removed flag
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/react/src/FeatureFlags/DefaultFeatureFlags.ts | Removed the primer_react_css_modules_ga feature flag entry |
packages/react/.storybook/preview.jsx | Removed PRIMER_REACT_CSS_MODULES_GA from the feature flag environment list |
Comments suppressed due to low confidence (1)
packages/react/.storybook/preview.jsx:237
- With an empty Set, the for loop on lines 236-237 will never execute. Consider removing this unused loop logic or adding a comment explaining why this structure is maintained for future feature flags.
const featureFlagEnvList = new Set([])
for (const flag of featureFlagEnvList) {
if (import.meta.env[`VITE_${flag}`] === '1') {
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
No description provided.