-
Notifications
You must be signed in to change notification settings - Fork 628
Remove sx prop in UnderlinePanels #6809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5e5e44f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the sx
prop from the UnderlinePanels component to simplify its API and reduce dependencies on the styled-components system. The changes focus on eliminating SxProp types and BoxWithFallback usage while transitioning to standard HTML element props.
Key Changes:
- Removed SxProp from UnderlinePanelsProps and TabProps type definitions
- Replaced BoxProps with React.HTMLAttributes for PanelProps
- Simplified Panel component implementation by removing BoxWithFallback dependency
const Panel: FC<PanelProps> = () => { | ||
return <div role="tabpanel" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Panel component no longer accepts or forwards any props. This breaks the component's functionality as it should receive and forward props like className, children, and other HTML attributes to the div element.
const Panel: FC<PanelProps> = () => { | |
return <div role="tabpanel" /> | |
const Panel: FC<PanelProps> = (props) => { | |
return <div role="tabpanel" {...props}>{props.children}</div> |
Copilot uses AI. Check for mistakes.
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
Closes ##6804
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist