Skip to content

Conversation

pksjce
Copy link
Contributor

@pksjce pksjce commented Sep 9, 2025

Closes ##6804

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings September 9, 2025 13:13
@pksjce pksjce requested a review from a team as a code owner September 9, 2025 13:13
@pksjce pksjce requested a review from TylerJDev September 9, 2025 13:13
Copy link

changeset-bot bot commented Sep 9, 2025

🦋 Changeset detected

Latest commit: 5e5e44f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the sx prop from the UnderlinePanels component to simplify its API and reduce dependencies on the styled-components system. The changes focus on eliminating SxProp types and BoxWithFallback usage while transitioning to standard HTML element props.

Key Changes:

  • Removed SxProp from UnderlinePanelsProps and TabProps type definitions
  • Replaced BoxProps with React.HTMLAttributes for PanelProps
  • Simplified Panel component implementation by removing BoxWithFallback dependency

Comment on lines 222 to 223
const Panel: FC<PanelProps> = () => {
return <div role="tabpanel" />
Copy link
Preview

Copilot AI Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Panel component no longer accepts or forwards any props. This breaks the component's functionality as it should receive and forward props like className, children, and other HTML attributes to the div element.

Suggested change
const Panel: FC<PanelProps> = () => {
return <div role="tabpanel" />
const Panel: FC<PanelProps> = (props) => {
return <div role="tabpanel" {...props}>{props.children}</div>

Copilot uses AI. Check for mistakes.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 9, 2025
Copy link
Contributor

github-actions bot commented Sep 9, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Sep 9, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.64 KB (0%)
packages/react/dist/browser.umd.js 88.73 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-6809 September 9, 2025 13:18 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6809 September 9, 2025 13:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant