-
Notifications
You must be signed in to change notification settings - Fork 630
feat(RelativeTime): remove support for sx prop #6827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 104291a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes support for the sx
prop from the RelativeTime
component as part of a migration strategy to eliminate styled-components dependencies. The changes include removing sx prop type definitions, updating component creation utilities, and adjusting Storybook configurations.
- Remove
sx
prop support fromRelativeTime
component - Refactor component creation utilities to eliminate styled-components dependency
- Update Storybook controls to exclude sx-related properties
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/styled-react/src/index.tsx | Adds RelativeTime wrapper with sx support to maintain backward compatibility in styled-react package |
packages/react/src/utils/create-component.ts | Removes styled-components and sx dependencies from component creation utility |
packages/react/src/RelativeTime/RelativeTime.stories.tsx | Updates Storybook controls to exclude sx prop |
packages/react/src/RelativeTime/RelativeTime.features.stories.tsx | Updates Storybook controls to exclude sx prop |
packages/react/src/RelativeTime/RelativeTime.docs.json | Removes sx prop from component documentation |
.changeset/short-cloths-deny.md | Documents the breaking change for version release |
…rt-for-sx-from-relative-time
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2639 |
🟢 ci completed with status |
Closes #6773
Changelog
New
Changed
Removed
sx
fromRelativeTime
Rollout strategy
This component has no
sx
usage in github-ui and can be safely migrated