Skip to content

fix(AnchoredOverlay): Remove use of useResponsiveValue #7098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix(AnchoredOverlay): Remove use of useResponsiveValue #7098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
08bccd3
fix(AnchoredOverlay): Remove use of useResponsiveValue
francinelucca Oct 29, 2025
a861141
remove needless disables
francinelucca Oct 29, 2025
0248342
Update packages/react/src/Overlay/Overlay.tsx
francinelucca Oct 29, 2025
71909ef
update snapshot
francinelucca Oct 29, 2025
e6779bb
Merge branch 'chore/anchored-overlay-ssr-fix' of github.com:primer/re…
francinelucca Oct 29, 2025
51a9e6c
css fix
francinelucca Oct 30, 2025
26457ee
add data-component attribute to AnchoredOverlay
francinelucca Oct 30, 2025
a5a39de
update snapshots
francinelucca Oct 30, 2025
f707eed
Merge branch 'main' into chore/anchored-overlay-ssr-fix
francinelucca Oct 30, 2025
c37bbf6
Merge branch 'main' into chore/anchored-overlay-ssr-fix
francinelucca Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {useFocusZone} from '../hooks/useFocusZone'
import {useAnchoredPosition, useProvidedRefOrCreate, useRenderForcingRef} from '../hooks'
import {useId} from '../hooks/useId'
import type {AnchorPosition, PositionSettings} from '@primer/behaviors'
import {useResponsiveValue, type ResponsiveValue} from '../hooks/useResponsiveValue'
import {type ResponsiveValue} from '../hooks/useResponsiveValue'
import {IconButton, type IconButtonProps} from '../Button'
import {XIcon} from '@primer/octicons-react'
import classes from './AnchoredOverlay.module.css'
Expand Down Expand Up @@ -225,8 +225,6 @@ export const AnchoredOverlay: React.FC<React.PropsWithChildren<AnchoredOverlayPr
})
useFocusTrap({containerRef: overlayRef, disabled: !open || !position, ...focusTrapSettings})

const currentResponsiveVariant = useResponsiveValue(variant, 'anchored')

const showXIcon = onClose && variant.narrow === 'fullscreen' && displayCloseButton
const XButtonAriaLabelledBy = closeButtonProps['aria-labelledby']
const XButtonAriaLabel = closeButtonProps['aria-label']
Expand Down Expand Up @@ -254,13 +252,13 @@ export const AnchoredOverlay: React.FC<React.PropsWithChildren<AnchoredOverlayPr
visibility={position ? 'visible' : 'hidden'}
height={height}
width={width}
top={currentResponsiveVariant === 'anchored' ? position?.top || 0 : undefined}
left={currentResponsiveVariant === 'anchored' ? position?.left || 0 : undefined}
Comment on lines -257 to -258
Copy link
Member Author

@francinelucca francinelucca Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this css rule already takes care of resetting top/left, switched up the inline styles in the BaseOverlay as well to be css variables applied by the className so that they don't win over specificity

top={position?.top || 0}
left={position?.left || 0}
responsiveVariant={variant.narrow === 'fullscreen' ? 'fullscreen' : undefined}
data-variant={currentResponsiveVariant}
Copy link
Member Author

@francinelucca francinelucca Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from what I can tell there is not real usage to this

anchorSide={position?.anchorSide}
className={className}
preventOverflow={preventOverflow}
data-component="AnchoredOverlay"
{...overlayProps}
>
{showXIcon ? (
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/AnchoredOverlay/__snapshots__/AnchoredOverlay.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@ exports[`AnchoredOverlay > should render consistently when open 1`] = `
>
<div
class="prc-Overlay-Overlay-ViJgm"
data-component="AnchoredOverlay"
data-focus-trap="active"
data-height-auto=""
data-variant="anchored"
data-visibility-visible=""
data-width-auto=""
role="none"
style="left: 0px; top: 36px;"
style="--top: 36px; --left: 0px;"
>
<span
aria-hidden="true"
Expand Down
8 changes: 8 additions & 0 deletions packages/react/src/Overlay/Overlay.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@
background-color: var(--overlay-bgColor);
border-radius: var(--borderRadius-large);
box-shadow: var(--shadow-floating-small);
/* stylelint-disable-next-line primer/spacing */
top: var(--top, auto);
/* stylelint-disable-next-line primer/spacing */
left: var(--left, auto);
/* stylelint-disable-next-line primer/spacing */
right: var(--right, auto);
/* stylelint-disable-next-line primer/spacing */
bottom: var(--bottom, auto);

&:focus {
outline: none;
Expand Down
8 changes: 4 additions & 4 deletions packages/react/src/Overlay/Overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,10 @@ export const BaseOverlay = React.forwardRef(
ref={forwardedRef}
style={
{
left,
right,
top,
bottom,
'--top': typeof top === 'number' ? `${top}px` : top,
'--left': typeof left === 'number' ? `${left}px` : left,
'--right': typeof right === 'number' ? `${right}px` : right,
'--bottom': typeof bottom === 'number' ? `${bottom}px` : bottom,
position,
...styleFromProps,
} as React.CSSProperties
Expand Down
7 changes: 7 additions & 0 deletions packages/react/src/experimental/SelectPanel2/SelectPanel.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@
}
}

&:where([data-variant='modal']) {
top: 0;
left: 0;
right: 0;
bottom: 0;
}

&:where([data-variant='modal'])::backdrop {
background-color: var(--overlay-backdrop-bgColor);
}
Expand Down
Loading