Open
Conversation
Contributor
|
Could you investigate why these break? |
jijn
commented
Feb 14, 2026
| // Zero out the ghosts | ||
| Timer::start_section("Zero ghosts"); | ||
| this->get_solution_handler().zero_out_ghosts(); | ||
| Timer::end_section("Zero ghosts"); |
Contributor
Author
There was a problem hiding this comment.
should we do it here or in sequential_co_nonlinear_solver.cc|solve()?
jijn
commented
Feb 14, 2026
| // The solve will have updated the "old solution" vector with the newton update so it's | ||
| // technically the new solution. In order to update the solutions and preserve the old | ||
| // states we copy the old solution from above and swap. | ||
| *(this->get_solution_handler().get_new_solution_vector(variable.get_field_index())) = |
Contributor
Author
There was a problem hiding this comment.
old is const so we need to copy. But do we have to?
Contributor
Author
|
This is what I have for now. Could you take a look at the two questions above? sequantial_co_nonlinear_solver still has issues. I will continue working on it after grc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix Implicit Time Dependent Fields not updated every other time step #727
What is the current behavior? (You can also link to an open issue here)
fields not updated every other time step
What is the new behavior (if this is a feature change)?
they are updated correctly now.
For implicit, get_value(old1) should point to the solved solution of the previous step.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
I updated gold_output.txt for allen_cahn_implicit
Other information:
We need to wait for @fractalsbyx for the best solution.