Address last bit of outstanding TCP cleanup #41520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to improve the lifetime management of TCPEndPoint objects by consistently using TCPEndPointHandle in callbacks. The changes are generally good and follow this pattern. However, I've found a critical issue in the LwIP implementation (TCPEndPointImplLwIP.cpp) where some function calls were not updated to their new signatures, which will likely lead to compilation errors. I've also pointed out a minor typo in a comment. Please see the detailed comments for suggestions.
|
@gmarcosb could you describe more what What where the changes, why, why are they the correct ones? |
It's covered in the 2 issues linked to the PR which this PR will fix; the reason for this PR is to address those 2 outstanding issues (thus outstanding TCP cleanup) |
gmarcosb
commented
Oct 17, 2025
gmarcosb
commented
Oct 17, 2025
gmarcosb
force-pushed
the
tcp-followup
branch
from
a39762a to
04ee89b
Compare
|
PR #41520: Size comparison from c87ece5 to 04ee89b Full report (34 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
|
PR #41520: Size comparison from c87ece5 to c2826f9 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41520 +/- ##
==========================================
+ Coverage 51.00% 51.01% +0.01%
==========================================
Files 1385 1386 +1
Lines 100969 100980 +11
Branches 13079 13075 -4
==========================================
+ Hits 51500 51519 +19
+ Misses 49469 49461 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bzbarsky-apple
approved these changes
Oct 21, 2025
pidarped
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Address outstanding TCP cleanup
Related issues
Fixes #41453
Fixes #41404
Testing
CI
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines