Rename ValveConfigurationAndControl cluster files #41542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #41542: Size comparison from c1f377d to 744bac2 Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
|
PR #41542: Size comparison from c1f377d to 5821290 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41542 +/- ##
=======================================
Coverage 51.04% 51.04%
=======================================
Files 1386 1386
Lines 100958 100958
Branches 13061 13061
=======================================
Hits 51534 51534
Misses 49424 49424 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the ValveConfigurationAndControl cluster implementation files from valve-configuration-and-control-server.* to valve-configuration-and-control-cluster.* as preparation for migrating this cluster to a code-driven implementation. This follows the naming convention described in the SDK's cluster development guides.
Key Changes
- Renamed header and source files from
-serversuffix to-clustersuffix - Updated all references to the renamed files in build configuration files and example applications
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/clusters/valve-configuration-and-control-server/valve-configuration-and-control-cluster.cpp | Updated include statement to reference renamed header file |
| src/app/clusters/valve-configuration-and-control-server/app_config_dependent_sources.gni | Updated build configuration to reference renamed cluster files |
| src/app/clusters/valve-configuration-and-control-server/app_config_dependent_sources.cmake | Updated CMake build configuration to reference renamed cluster files |
| examples/all-clusters-app/linux/main-common.cpp | Updated include statement to reference renamed header file |
| examples/all-clusters-app/linux/ValveControlDelegate.cpp | Updated include statement to reference renamed header file |
andy31415
approved these changes
Oct 21, 2025
andy31415
added
the
sdk-maintainer-approved
|
PR #41542: Size comparison from 7e83b9f to a78b93d Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
bzbarsky-apple
approved these changes
Oct 21, 2025
juandediosg
pushed a commit
to juandediosg/connectedhomeip
that referenced
this pull request
Dec 9, 2025
* Rename ValveConfigurationAndControl cluster files * Restyled by gn --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is just a rename of the ValveConfigurationAndControl cluster files in preparation for the code driven migration of this cluster.
Testing
Compiled unit tests but the CI should confirm if there are any breaking links after the rename, no real code change was added (only the header references in some examples).