[chip-tool] make discover commissionables return a list of all discovered devices instead of only one
#41545
+1
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #41545: Size comparison from c1f377d to d6003fe Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41545 +/- ##
=======================================
Coverage 51.04% 51.04%
=======================================
Files 1384 1386 +2
Lines 100937 100956 +19
Branches 13059 13061 +2
=======================================
+ Hits 51521 51534 +13
- Misses 49416 49422 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Alami-Amine
changed the title
discover commissionables return a list of all discovered devices instead of only one
Alami-Amine
changed the title
discover commissionables return a list of all discovered devices instead of only onediscover commissionables return a list of all discovered devices instead of only one
| LogErrorOnFailure(RemoteDataModelLogger::LogDiscoveredNodeData(nodeData)); | ||
|
|
||
| if (mDiscoverOnce.ValueOr(true)) | ||
| if (mDiscoverOnce.ValueOr(false)) |
There was a problem hiding this comment.
This is documented as defaulting to true, no?
As in, the documented behavior matches the implemented behavior. I am not sure where "Documentation of chip-tool mentions that it should mention all discovered commissionables" comes from. If it's from some sort of out-of-band documentation, that just means that documentation is wrong...
There was a problem hiding this comment.
- Yaa it is documented that it "defaults as true" in the Code, but here for example it mentions 'all matter commissionables':
connectedhomeip/docs/development_controllers/chip-tool/chip_tool_guide.md
Lines 892 to 896 in a343518
There was a problem hiding this comment.
Do you need it to be defaulted as True? as it seems incoherent with the even the name of the command commissionableS
There was a problem hiding this comment.
It's possible the guide was written before this option was introduced; the dangers of out-of-band documentation. Like #25223 (thank you for finding that) explains, the option defaults to true to match the Python harness behavior, so that YAML and Python tests behave the same wrt discovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
discover commissionablescommand only diplays one discovery result and then exitsTesting
CI Testing